FlagPole/tests/FeatureManagerTest.php

208 lines
7.7 KiB
PHP
Raw Permalink Normal View History

2025-12-09 22:48:07 +00:00
<?php
declare(strict_types=1);
namespace FlagPole\Tests;
use FlagPole\Context;
use FlagPole\FeatureManager;
use FlagPole\Repository\InMemoryFlagRepository;
use PHPUnit\Framework\TestCase;
use Psr\Log\AbstractLogger;
2025-12-09 22:48:07 +00:00
final class FeatureManagerTest extends TestCase
{
public function testExplicitEnabledOverrides(): void
{
$repo = InMemoryFlagRepository::fromArray([
'hard-on' => ['enabled' => true],
'hard-off' => ['enabled' => false],
]);
$fm = new FeatureManager($repo);
$this->assertTrue($fm->isEnabled('hard-on'));
$this->assertFalse($fm->isEnabled('hard-off', null, true));
}
public function testLogging(): void
{
$logger = new class extends AbstractLogger {
public array $logs = [];
public function log($level, string|\Stringable $message, array $context = []): void
{
$this->logs[] = (string)$message;
}
};
$repo = InMemoryFlagRepository::fromArray([
'test-flag' => ['enabled' => true],
]);
$fm = new FeatureManager($repo, null, $logger);
$fm->isEnabled('test-flag');
$this->assertCount(1, $logger->logs);
$this->assertStringContainsString('Flag "test-flag" evaluated to TRUE via explicit "enabled" override', $logger->logs[0]);
}
2025-12-09 22:48:07 +00:00
public function testAllowListWins(): void
{
$repo = InMemoryFlagRepository::fromArray([
'flag' => [
'enabled' => false,
'allowList' => ['user_1'],
],
]);
$fm = new FeatureManager($repo);
$ctx1 = Context::fromArray(['userId' => 'user_1']);
$ctx2 = Context::fromArray(['userId' => 'user_2']);
$this->assertTrue($fm->isEnabled('flag', $ctx1));
$this->assertFalse($fm->isEnabled('flag', $ctx2));
}
public function testPercentageRolloutIsStable(): void
{
$repo = InMemoryFlagRepository::fromArray([
'gradual' => [
'rolloutPercentage' => 10,
],
]);
$fm = new FeatureManager($repo);
$ctx = Context::fromArray(['userId' => 'user_42']);
$first = $fm->isEnabled('gradual', $ctx);
$second = $fm->isEnabled('gradual', $ctx);
$this->assertSame($first, $second, 'Rollout decision should be stable for same user');
}
public function testRolloutBoundaryPercentages(): void
{
$repo = InMemoryFlagRepository::fromArray([
'zero' => [ 'rolloutPercentage' => 0 ],
'hundred' => [ 'rolloutPercentage' => 100 ],
]);
$fm = new FeatureManager($repo);
$ctx = Context::fromArray(['userId' => 'any_user']);
$this->assertFalse($fm->isEnabled('zero', $ctx), '0% rollout should always be false when key present');
$this->assertTrue($fm->isEnabled('hundred', $ctx), '100% rollout should always be true when key present');
}
public function testRolloutEdgeCasesOneAndNinetyNinePercent(): void
{
$repo = InMemoryFlagRepository::fromArray([
'one' => [ 'rolloutPercentage' => 1 ],
'ninetyNine' => [ 'rolloutPercentage' => 99 ],
'hundred' => [ 'rolloutPercentage' => 100 ],
]);
$fm = new FeatureManager($repo);
// Find a user that gets bucket < 1 (i.e., enabled at 1%)
$foundOne = null;
for ($i = 0; $i < 5000; $i++) {
$ctx = Context::fromArray(['userId' => 'u'.$i]);
if ($fm->isEnabled('one', $ctx)) { // enabled under 1%
$foundOne = $ctx;
break;
}
}
$this->assertNotNull($foundOne, 'Should find a user enabled at 1% within a reasonable search space');
// Find a user that is NOT enabled at 99% but is at 100%
$foundFalseAt99 = null;
for ($i = 0; $i < 5000; $i++) {
$ctx = Context::fromArray(['userId' => 'v'.$i]);
if (!$fm->isEnabled('ninetyNine', $ctx) && $fm->isEnabled('hundred', $ctx)) {
$foundFalseAt99 = $ctx;
break;
}
}
$this->assertNotNull($foundFalseAt99, 'Should find a user disabled at 99% but enabled at 100%');
}
public function testPercentageRolloutWithMissingTargetingKeyFallsBackToDefault(): void
{
$repo = InMemoryFlagRepository::fromArray([
'gradual' => [ 'rolloutPercentage' => 50 ],
]);
$fm = new FeatureManager($repo);
// No context provided
$this->assertFalse($fm->isEnabled('gradual', null, false));
$this->assertTrue($fm->isEnabled('gradual', null, true));
// Empty context (no targeting attributes)
$emptyCtx = Context::fromArray([]);
$this->assertFalse($fm->isEnabled('gradual', $emptyCtx, false));
$this->assertTrue($fm->isEnabled('gradual', $emptyCtx, true));
}
public function testRulesMatching(): void
{
$repo = InMemoryFlagRepository::fromArray([
'beta-users' => [
'rules' => [
['attribute' => 'group', 'operator' => 'eq', 'value' => 'beta'],
],
],
'version-check' => [
'rules' => [
['attribute' => 'version', 'operator' => 'gte', 'value' => '2.0'],
],
],
'multi-rules' => [
'rules' => [
['attribute' => 'plan', 'operator' => 'in', 'value' => ['pro', 'enterprise']],
['attribute' => 'region', 'operator' => 'eq', 'value' => 'us-east'],
],
],
]);
$fm = new FeatureManager($repo);
// Single rule 'eq'
$this->assertTrue($fm->isEnabled('beta-users', Context::fromArray(['group' => 'beta'])));
$this->assertFalse($fm->isEnabled('beta-users', Context::fromArray(['group' => 'standard'])));
// Single rule 'gte'
$this->assertTrue($fm->isEnabled('version-check', Context::fromArray(['version' => '2.0'])));
$this->assertTrue($fm->isEnabled('version-check', Context::fromArray(['version' => '2.1'])));
$this->assertFalse($fm->isEnabled('version-check', Context::fromArray(['version' => '1.9'])));
// Multi rules (OR behavior because it matches ANY rule in the list as implemented currently)
// Wait, the plan said: "Precedence: allowList > enabled > rules > rolloutPercentage"
// And the implementation I did:
/*
if (!empty($flag->rules)) {
foreach ($flag->rules as $rule) {
if ($this->matchRule($rule, $context)) {
return true;
}
}
}
*/
// This is indeed OR behavior. If ANY rule matches, it returns true.
$this->assertTrue($fm->isEnabled('multi-rules', Context::fromArray(['plan' => 'pro'])));
$this->assertTrue($fm->isEnabled('multi-rules', Context::fromArray(['region' => 'us-east'])));
$this->assertFalse($fm->isEnabled('multi-rules', Context::fromArray(['plan' => 'free', 'region' => 'eu-west'])));
}
public function testExplicitTargetingKey(): void
{
$repo = InMemoryFlagRepository::fromArray([
'custom-key' => [
'targetingKey' => 'orgId',
'allowList' => ['org_123'],
],
]);
$fm = new FeatureManager($repo);
$ctxMatched = Context::fromArray(['orgId' => 'org_123']);
$ctxUnmatched = Context::fromArray(['orgId' => 'org_456', 'userId' => 'org_123']); // userId matches but orgId doesn't
$this->assertTrue($fm->isEnabled('custom-key', $ctxMatched));
$this->assertFalse($fm->isEnabled('custom-key', $ctxUnmatched));
}
2025-12-09 22:48:07 +00:00
}