getphred/FlagPole
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: resolve PHPStan redundant check errors in FlagHydrator
Some checks are pending
CI / PHP ${{ matrix.php }} (8.2) (push) Waiting to run
Details
CI / PHP ${{ matrix.php }} (8.3) (push) Waiting to run
Details

Browse source
This commit is contained in:
Funky Waddle 2026-02-12 01:06:57 -06:00
parent b7b534fa5a
commit 866c614965
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/FlagHydrator.php
View file

@ -15,7 +15,7 @@ final class FlagHydrator
/** /**
* @param string $name * @param string $name
* @param array{enabled?:bool|null, rolloutPercentage?:int|null, allowList?:list<string>, rules?:list<array{attribute:string, operator:string, value:mixed}>, targetingKey?:string|null} $data * @param array<string, mixed> $data
* @return Flag * @return Flag
*/ */
public function hydrate(string $name, array $data): Flag public function hydrate(string $name, array $data): Flag
@ -23,7 +23,7 @@ final class FlagHydrator
$rules = []; $rules = [];
if (isset($data['rules']) && is_array($data['rules'])) { if (isset($data['rules']) && is_array($data['rules'])) {
foreach ($data['rules'] as $ruleDef) { foreach ($data['rules'] as $ruleDef) {
if (!isset($ruleDef['attribute'], $ruleDef['operator'], $ruleDef['value'])) { if (!is_array($ruleDef) || !isset($ruleDef['attribute'], $ruleDef['operator'], $ruleDef['value'])) {
throw new \InvalidArgumentException(sprintf('Invalid rule definition for flag "%s". Missing attribute, operator, or value.', $name)); throw new \InvalidArgumentException(sprintf('Invalid rule definition for flag "%s". Missing attribute, operator, or value.', $name));
} }